Skip to content

CI: VRF unit tests run as part of unit-tests#1684

Merged
dannywillems merged 1 commit intodevelopfrom
dw/unit-test-vrf
Dec 1, 2025
Merged

CI: VRF unit tests run as part of unit-tests#1684
dannywillems merged 1 commit intodevelopfrom
dw/unit-test-vrf

Conversation

@dannywillems
Copy link
Copy Markdown
Contributor

@dannywillems dannywillems commented Dec 1, 2025 •
edited
Loading

There are no integrations tests (following the Rust naming convention described here), only unit tests.

@dannywillems dannywillems self-assigned this Dec 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 763b0dc642aa6c377233a2272c45742a0ee35e11

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 763b0dc642aa6c377233a2272c45742a0ee35e11)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

@dannywillems dannywillems moved this to Todo in Rust node Dec 1, 2025
@dannywillems dannywillems moved this from Todo to In Progress in Rust node Dec 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

richardpringle
richardpringle requested changes Dec 1, 2025
View reviewed changes
.github/workflows/tests.yaml
--exclude libp2p-rpc-behaviour \
--exclude node \
--exclude mina-node-account \
--exclude vrf \
Copy link
Copy Markdown
Collaborator

@richardpringle richardpringle Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this down to a comment at the bottom? Just helps us keep track of what's explicitly being run. Once we stop excluding most tests, we can delete the comment

Copy link
Copy Markdown
Contributor Author

@dannywillems dannywillems Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and pushed forced.

@dannywillems dannywillems merged commit b7be0be into develop Dec 1, 2025
74 checks passed
@dannywillems dannywillems moved this from In Progress to Done in Rust node Dec 3, 2025
@dannywillems dannywillems deleted the dw/unit-test-vrf branch December 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardpringle richardpringle richardpringle approved these changes

Assignees

@dannywillems dannywillems

Labels

no changelog

Projects

Rust node
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dannywillems @richardpringle